Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add the color LightGreen (LG) to the color maps #271

Open
Halfwalker opened this issue Feb 2, 2022 · 1 comment
Open

[feature] Add the color LightGreen (LG) to the color maps #271

Halfwalker opened this issue Feb 2, 2022 · 1 comment

Comments

@Halfwalker
Copy link

For automotive wiring all the colors are represented, except for Light Green. The standard colors are
image
It would be nice to be able to specify colors via that code, but certainly not necessary.

@kvid
Copy link
Collaborator

kvid commented Feb 3, 2022

Yes, this has been discussed earlier as well, e.g. in #135 (comment), and the on-going PR #251 probably includes new methods for specifying colors. You can take a preliminary look at that branch, but note that this PR is still unfinished, and might change a lot before merging into the dev branch.

With the current version of WireViz, you can always specify colors by hexadecimal RGB values, like "#00FF00" or "#008800". If you really need to use LG as a color, nobody stops you from adding this in your local wv_colors.py, but then be aware that your harnesses containing such custom colors cannot be processed correctly by normal WireViz installations (e.g. if you share such a harness YAML file with others).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants