-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors in beforeDelete are not shown to the user #822
Comments
The error is because |
winter/modules/backend/assets/js/winter.alert.js Lines 21 to 36 in 68b9a55
|
@multiwebinc thanks for the report. Confirmed the issue - will try and investigate a fix. |
@bennothommo Maybe upgrading to SweetAlert 2 would be an option since it is promise-based. They even have an ajax request example in the docs. |
@bennothommo any updates? |
Not at this stage. |
Open for anyone who wants to submit a PR to fix it if they want it fixed; otherwise I'll just let the bot close it next time it comes up. |
Winter CMS Build
1.2
PHP Version
8.1
Database engine
SQLite
Plugins installed
No response
Issue description
When saving a model, the following code causes the error message to be displayed to the user:
However when deleting the model, the following code does not display the error to the user:
The request responses appear to be the same (i.e. both return 500 status code and just the error message string), so I would assume the bug lies somewhere in the client-side code.
Steps to replicate
(see description)
Workaround
No response
The text was updated successfully, but these errors were encountered: