Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] show file被归为open file event进而触发自定义脚本 #328

Closed
2 tasks done
ramonmi opened this issue May 21, 2024 · 1 comment
Closed
2 tasks done

[Bug] show file被归为open file event进而触发自定义脚本 #328

ramonmi opened this issue May 21, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@ramonmi
Copy link

ramonmi commented May 21, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Are you using the latest Zotero and the latest plugin?

  • I have confirmed I'm using the latest Zotero and the latest plugin

Environment

  • OS: Win11
  • Zotero Version: beta7.79
  • Plugin Version: 1.0.0-beta.39

Describe the bug

我自定义的添加/reading标签的脚本,触发事件选择的插件预置的open file,然而今天发现在parent item或者attachment邮件show file,也会触发改脚本。
猜测是因为插件本身将show file归为了open file事件的一种?然而是否应该将open file限定为open in new tab或者open in new window(或者再加上外部程序打开),而不应该包含show file呢。

Debug Output

none

Anything else?

No response

@ramonmi ramonmi added the bug Something isn't working label May 21, 2024
@windingwind
Copy link
Owner

show file 本身会触发open file的notifier,因此被插件认为是打开文件。由于无法检测open in new window,因此只能检测open file。谢谢建议

@windingwind windingwind closed this as not planned Won't fix, can't repro, duplicate, stale Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants