Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H[ome] on Safari/iOS can require two presses to get to home location #283

Closed
nbriggs opened this issue Dec 21, 2023 · 8 comments
Closed

Comments

@nbriggs
Copy link

nbriggs commented Dec 21, 2023

When you touch "H", and iOS prompts for permission to provide location information, the map display is moved to the NY area before permission is given and does not move to the home location after permission is given, necessitating a second press of the "H" button to redisplay at the desired location.

@mpentler
Copy link
Contributor

Have also seen this, have you seen it every single time? I'm not sure I have had it happen on every occasion.

@nbriggs
Copy link
Author

nbriggs commented May 26, 2024

@mpentler it may indeed not be every single time, but it's certainly most of the time for me. It'll typically be first thing in the AM after the phone has been idle overnight and I switch to the tab with the virtual radar display running, but the home location dot has disappeared.

@wiedehopf
Copy link
Owner

What site exactly do you have open?

Also you should really be able to allow the domain to permanently access the location.

@nbriggs
Copy link
Author

nbriggs commented May 26, 2024

https://globe.adsbexchange.com/

I probably could set it to Allow, but I have it set to Ask.

@wiedehopf
Copy link
Owner

First of all that code is not the same as this code anymore.
For some time.
So even if i were to make changes, would take quite some time to possibly get merged over there.

And yes you could just allow it.
That would mean it would just keep updating the even if you move.
Pretty much that's the two use cases i considered: either you deny it forever and just not use the H button, or you allow permanently and it keeps updating the device location.

Maybe i test your use case at some point on android, i guess i should be able to reproduce it.

@nbriggs
Copy link
Author

nbriggs commented May 26, 2024

I don't know how Android behaves with regard to the location when location permission is denied. In fact, I'm not sure how iOS behaves either: whether it gives a fake location, or returns an error (or throws an exception) when asked. On the application side - which you know and I don't - it could be using a default location (and influencing the framing) if denied rather than the current framing of the map just without the current location dot.

@wiedehopf
Copy link
Owner

So while this is fixed in my branch, i have no control over adsbexchanges website.

If you supply data, consider some variety in sites to feed, for example using this image: https://adsb.im/

I'd expect this change to propagate soon to some of the other websites that use this interface (for example https://adsb.lol/)

@nbriggs
Copy link
Author

nbriggs commented May 27, 2024

Nice, thanks! I'll see if I can prod the ADSBExchange people to update. I'm not a feeder - I live in the SF Bay area where there seems to be very good coverage already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants