-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Antialiasing #406
Comments
part2 r101 didn't work because of a stencil format issue which was fixed in r106. r106 didn't work because for some reason rendering to the multisampled target would force clear. So I decided to try r137 and there the issue has been resolved. The necessary adjustments to ipyvolume were minor, just one obstacle remained: pythreejs deserializes the ShaderMaterial objects without three.ShaderMaterial as prototype. I "fixed" it by using Object.setPrototypeOf just before the exception (before material.onBeforeRender in three.module.js:~27080). Obviously volume rendering is still broken, but maybe the remaining issues are easier to solve. Long story short: I believe ipyvolume would benefit from a more recent version of threejs. Afaik the main obstacle is pythreejs which isn't going to support newer releases of threejs anytime soon (jupyter-widgets/pythreejs#359). Anyways, it was a fun experience and maybe someday its actually useful. If anyone is interested, I will fork and push the changes. |
Hi,
I did some surface and line plots recently and found the amount of aliasing rather distracting. Then I discovered SMAA and SSAA postprocessing in three.js and tried to add them to the plots. After a lot of trial and error (I'm not really familiar with js/ts and dev workflow) I was lucky and got:
(from left to right: master branch, master + smaa, master + ssaa)
There is
WebGLRenderer(...antialias=true...)
but never saw any antialiasing applied. Are plots supposed to be antialiased? If not, optional SSAA would be a very nice feature.Misc:
The text was updated successfully, but these errors were encountered: