-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
offline=True in embed_html failing to save required file js/jupyter-threejs.js #192
Comments
It's possible this is wholly or partially resolved by the offline_embed branch here: https://github.com/maartenbreddels/ipyvolume/tree/offline_embed |
That branch is old, I'll remove it. Seems like a legit bug. |
Maybe related: I was wondering if it would be of general use to have a no dependencies option for the offline html? It'd be useful in situations where you write many html files to the same location, and care about how fast you can write them to disk. |
Yes, a cache would be nice, I think though it should (optionally) check the CDN for the right version, and if not it should update it. My guess is that the request package can do this. I also hate that it downloads everything every time. It can also do a hardlink to the cached file (for non-windows users). |
The
offline=True
kwarg inipyvolume.embed.embed_html()
is failing to save the file at https://unpkg.com/[email protected]/dist/index.js locally asjs/jupyter-threejs.js
Copying that file manually into
js/jupyter-threejs.js
fixes the issue and allows offline viewing.I'm using ipyvolume installed from master branch: 0.5.2-dev.1
The text was updated successfully, but these errors were encountered: