Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider toggle to auto-add preview image when only one image in folder #827

Open
whyboris opened this issue Oct 4, 2023 · 4 comments
Open

Comments

@whyboris
Copy link
Owner

whyboris commented Oct 4, 2023

🤔 may be easy - but will require a check-box during the creation of the hub, which is easy to do but perhaps hard to communicate its behavior 🤔

If check-box checked during creation of hub, pull in cover.jpg or cover.png automatically, or if the folder has only one video file and only one image file inside it (😓 may be annoying to check - what if there is some .txt in there as well) 🤷‍♂️

Not an important feature, but might be worth trying 🤷

@K-Vishwak
Copy link

K-Vishwak commented Oct 21, 2023

I will take this up. Can you help me set up in my local?

@whyboris
Copy link
Owner Author

Hey @K-Vishwak - please see basic instructions here: Readme

Basically you need Node installed (comes with npm) and then after you clone this repository to your local machine, just npm install --legacy-peer-deps and then npm start

Let me know if you have trouble 🤝

@K-Vishwak
Copy link

K-Vishwak commented Oct 23, 2023

Thanks for the input. I am able to run in my local.

Now want to understand what to implement.

Where to add this preview image based on the checkbox?

@whyboris
Copy link
Owner Author

Sorry missed this response with a question 😓

The default screenshot for every video is currently generated with FFmpeg and is placed inside thumbnails folder. There is already functionality that lets users drag & drop an image over a video in VHA and make it the default thumbnail for the video (replacing the one previously generated).

The issue / improvement proposed here is to instead use the cover.jpg from the folder instead of extracting the screenshot from the video.

Since we can re-use the function that handles inserting image from drag & drop, this feature might not be too annoying to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants