Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyError crash when ripping unknown disc with %N in track template #585

Open
elomatreb opened this issue Jan 14, 2023 · 1 comment
Open

Comments

@elomatreb
Copy link

I tried ripping a disc that was not yet added to MusicBrainz (with the --unknown option), and I had the following track_template: %%A - %%d/%%N-%%t %%n.

This then resulted in the following crash:

Traceback (most recent call last):
  File "/usr/bin/whipper", line 33, in <module>
    sys.exit(load_entry_point('whipper==0.10.0', 'console_scripts', 'whipper')())
  File "/usr/lib/python3.10/site-packages/whipper/command/main.py", line 56, in main
    ret = cmd.do()
  File "/usr/lib/python3.10/site-packages/whipper/command/basecommand.py", line 141, in do
    return self.cmd.do()
  File "/usr/lib/python3.10/site-packages/whipper/command/basecommand.py", line 141, in do
    return self.cmd.do()
  File "/usr/lib/python3.10/site-packages/whipper/command/cd.py", line 203, in do
    ret = self.doCommand()
  File "/usr/lib/python3.10/site-packages/whipper/command/cd.py", line 559, in doCommand
    _ripIfNotRipped(i + 1)
  File "/usr/lib/python3.10/site-packages/whipper/command/cd.py", line 420, in _ripIfNotRipped
    path = self.program.getPath(self.program.outdir,
  File "/usr/lib/python3.10/site-packages/whipper/common/program.py", line 244, in getPath
    return os.path.join(outdir, template % v_fltr)
KeyError: 'N'

Removing %%N from the template string allowed me to rip the disc successfully.

@github-actions
Copy link

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant