Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifact, on open in linux without ROM #121

Open
GabrielBRDeveloper opened this issue Jul 17, 2023 · 17 comments
Open

Artifact, on open in linux without ROM #121

GabrielBRDeveloper opened this issue Jul 17, 2023 · 17 comments

Comments

@GabrielBRDeveloper
Copy link
Contributor

OS: LinuxMint 21.1
Kernel: 5.15.0-76-generic

image

@wheremyfoodat
Copy link
Owner

How did you install this? Maybe try compiling from source?

@GabrielBRDeveloper
Copy link
Contributor Author

Builded from source

@wheremyfoodat
Copy link
Owner

Does it work if you load a ROM eg Ocarina of Time? What's your GPU?

@GabrielBRDeveloper
Copy link
Contributor Author

in the precompiled version, it doesn't even display the window.

@wheremyfoodat
Copy link
Owner

Yeah the precompiled builds aren't really portable because shipping software on Linux is not a fun experience

@wheremyfoodat
Copy link
Owner

Potentially fixed in #259?

@GabrielBRDeveloper
Copy link
Contributor Author

Not resolved.

image

image

@wheremyfoodat
Copy link
Owner

Could you try loading a ROM? Also please post your specs and any important information if possible.

@GabrielBRDeveloper
Copy link
Contributor Author

My system:

image

I will test Zelda Ocarina, and return with a feedback

@wheremyfoodat
Copy link
Owner

Thanks!

@GabrielBRDeveloper
Copy link
Contributor Author

did error:

image

Unhandled SIGSEGV at rip 0x00007f62d19a9c9d Falha de segmentação (imagem do núcleo gravada)

@wheremyfoodat
Copy link
Owner

Uh that's bad. Does this ROM run on Citra?

@GabrielBRDeveloper
Copy link
Contributor Author

too crash in recent citra version, i go to check the rom file.

@GabrielBRDeveloper
Copy link
Contributor Author

image

@GabrielBRDeveloper
Copy link
Contributor Author

It's working.

@GabrielBRDeveloper
Copy link
Contributor Author

The artifact is caused because is not none rendering in moment, on edit code in emulator.cpp:


void Emulator::runFrame() {
	if (running) {
		cpu.runFrame(); // Run 1 frame of instructions
		gpu.display();  // Display graphics

		// Send VBlank interrupts
		ServiceManager& srv = kernel.getServiceManager();
		srv.sendGPUInterrupt(GPUInterrupt::VBlank0);
		srv.sendGPUInterrupt(GPUInterrupt::VBlank1);

		// Run cheats if any are loaded
		if (cheats.haveCheats()) [[unlikely]] {
			cheats.run();
		}
	} else if (romType != ROMType::None) {
		// If the emulator is not running and a game is loaded, we still want to display the framebuffer otherwise we will get weird
		// double-buffering issues
		gpu.display();
	}
}


removing the if (romType != ROMType::None)


} else {
		// If the emulator is not running and a game is loaded, we still want to display the framebuffer otherwise we will get weird
		// double-buffering issues
		gpu.display();
	}

The artifact fades aways.

@wheremyfoodat
Copy link
Owner

OK then I am likely forgetting to clear a texture somewhere. I'll check it out.
Though thankfully the emu still works itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants