Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ButtonLink componet will escape '&' to '&' when the href includes '&' #315

Closed
1 task done
zyc8988 opened this issue May 15, 2024 · 1 comment
Closed
1 task done
Labels
Good First Issue Misc: Good First Issue

Comments

@zyc8988
Copy link

zyc8988 commented May 15, 2024

Describe the bug

the code is:
<Button.Link href="http://a.com?a=1&b=2"></Button.Link>

and then it will excape the link into 'http://a.com?a=1&amp;b=2', which is invalid when visit 'a.com'

expect:
'&' will be still '&', not '&amp'

Link to Minimal Reproducible Example

No response

Steps To Reproduce

No response

Frog Version

0.9.4

TypeScript Version

No response

Check existing issues

Anything else?

No response

@tmm tmm added the Good First Issue Misc: Good First Issue label May 15, 2024
@hi-nikhil
Copy link

encountering the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Misc: Good First Issue
Projects
None yet
Development

No branches or pull requests

3 participants