-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External fonts are rendered inconsistently #303
Comments
Can we close this now? |
No, still reproducible. taking a look at it rn. |
The core issue arises from the fact that Since Moreover, trying to pass non-local fonts would not also work because of this: Lines 580 to 581 in a98f567
considering the mentioned above, I don't think it's worth making it work since user can define fonts in |
Thanks for digging into this guys. Can you also clarify in the docs where this overlaps with using a local/custom font within Frog UI here? Seems the same implementation works over there. |
I can confirm that declaring fonts in the Frog constructor works. To me that's enough since fonts can be imported there and used everywhere. I can't think of an scenario where that wouldn't be enough. I'd only suggest making it VERY clear in the docs and that's it. Thanks! |
* fix: delete `font` from frame response `imageOptions` Closes #303 * chore: changesets * fix: types * fix: build * nit: prettify 💅
Describe the bug
ref: #215 (comment)
Looks like fonts are not applied when fetched inside frame handler.
Link to Minimal Reproducible Example
https://github.com/dalechyn/frog-font-inconsistency
Steps To Reproduce
No response
Frog Version
0.9.2
TypeScript Version
5.4.5
Check existing issues
Anything else?
No response
The text was updated successfully, but these errors were encountered: