Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevTools: incorrect parsing behavior for image URLs from frame responses #299

Closed
1 task done
darrylyeo opened this issue May 4, 2024 · 2 comments · Fixed by #335
Closed
1 task done

DevTools: incorrect parsing behavior for image URLs from frame responses #299

darrylyeo opened this issue May 4, 2024 · 2 comments · Fixed by #335
Labels
Good First Issue Misc: Good First Issue

Comments

@darrylyeo
Copy link

darrylyeo commented May 4, 2024

Describe the bug

When using frog's standalone DevTools, og:image and fc:frame:image URLs containing & gets parsed as & when returned from frame action POST responses.

Screenshot 2024-05-03 at 14 28 30

Link to Minimal Reproducible Example

No response

Steps To Reproduce

  • Make a (non-frog) frame with a button
  • In the frame response, return https://example.com?a=1&b=2&c=3 as the fc:frame:image URL.
  • Start frog dev tools in standalone mode and navigate.

Frog Version

0.9.0

TypeScript Version

No response

Check existing issues

Anything else?

No response

@dalechyn
Copy link
Collaborator

dalechyn commented May 4, 2024

looking at the tests, this is expected in frog as it decodes amps properly.

@tmm, is standalone devtools purpose includes supporting debugging of non-frog frames? if no, this can be closed as won't fix.

@tmm
Copy link
Member

tmm commented May 15, 2024

Standalone mode is supposed to work on non-frog frames!

@tmm tmm added the Good First Issue Misc: Good First Issue label May 15, 2024
@tmm tmm closed this as completed in #335 May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Misc: Good First Issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants