Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate Waltz admin protocol #21

Open
whynick1 opened this issue Jul 8, 2019 · 2 comments
Open

Eliminate Waltz admin protocol #21

whynick1 opened this issue Jul 8, 2019 · 2 comments

Comments

@whynick1
Copy link
Contributor

whynick1 commented Jul 8, 2019

Because we decide to add 32 (or 64) bit Flags to distinguish a regular request from an admin request, like

public HelloRequest(String greeting, Flags flags) {
 this.greeting = greeting;
 this.flags = flags;
}

admin protocol is not needed anymore. So, we want to

  1. eliminate Waltz admin handler and admin port
  2. instead use Flags to replace existing admin related request.
@whynick1
Copy link
Contributor Author

whynick1 commented Jul 8, 2019

  1. eliminate Waltz admin handler and admin port

^ For that part, we should make sure we include SRE in this decision. For dropwizard services they are moving TOWARD having an admin port. Given that we don't have full AuthN/AuthZ, we need to be thoughtful about this.

@whynick1
Copy link
Contributor Author

whynick1 commented Jul 8, 2019

This requires Riff change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant