New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose close callback #613
Comments
I patched it such that if the callback is supplied it uses the callback for error instead of emitting. |
Your pull request is failing the code checks. You'll want to update it to keep from failing. It will hopefully get merged after that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
You have a
.close(code, data)
method here:https://github.com/websockets/ws/blob/master/lib/WebSocket.js#L100
But you don't expose the callback here:
https://github.com/websockets/ws/blob/master/lib/WebSocket.js#L121
The text was updated successfully, but these errors were encountered: