Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chunks are not processed #93

Open
ghost opened this issue Mar 18, 2019 · 5 comments
Open

Chunks are not processed #93

ghost opened this issue Mar 18, 2019 · 5 comments

Comments

@ghost
Copy link

ghost commented Mar 18, 2019

I have a minimal React setup here that outputs three chunks (runtime, common, and main). The plugin seems to only process the main chunk and output blank for the others.

@saksmt
Copy link

saksmt commented Dec 7, 2019

Any progress on this?

@tadjohnston
Copy link

tadjohnston commented Feb 21, 2020

What's the error you're getting on this? I'm getting what I think is an error similar to what you see:

/Users/tjohnston/source/rent-js/node_modules/closure-webpack-plugin/src/closure-compiler-plugin.js:1086
      chunk.hasEntryModule()
            ^

TypeError: Cannot read property 'hasEntryModule' of undefined
    at ClosureCompilerPlugin.getChunkName (/Users/tjohnston/source/rent-js/node_modules/closure-webpack-plugin/src/closure-compiler-plugin.js:1086:13)
    at /Users/tjohnston/source/rent-js/node_modules/closure-webpack-plugin/src/closure-compiler-plugin.js:673:22

I'm only getting this in AGGRESSIVE_BUNDLE, not STANDARD.

@Grundik
Copy link

Grundik commented Feb 18, 2021

Problem are still actual. No error messages are reported, plugin just dont process any chunk except main one.

@Grundik
Copy link

Grundik commented Feb 18, 2021

Simple repository (based on webpack guides), where this problem can be reproduced, can be found here.

Webpack would generate two chunks:

  • main.js which is minified by google closure compiler;
  • 1.main.js, not minified at all.

@Grundik
Copy link

Grundik commented Feb 19, 2021

I investigated this issue, and it comes to this line:

If one removes that block, all chunks would be minimized. It is a pity that the developers did not find time to take a look for such trivial thing in two years.

Grundik added a commit to Grundik/closure-webpack-plugin that referenced this issue Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants