-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialog styling does not respect theme roundness value #386
Comments
Hey! Thanks for opening the issue. Can you provide a minimal repro which demonstrates the issue? Posting a snippet of your code in the issue is useful, but it's not usually straightforward to run. A repro will help us debug the issue faster. Please try to keep the repro as small as possible. The easiest way to provide a repro is on snack.expo.dev. If it's not possible to repro it on snack.expo.dev, then you can also provide the repro in a GitHub repository. |
PRs are welcome! |
Hey! Thanks for opening the issue. Can you provide more information about the issue? Please fill the issue template when opening the issue without deleting any section. We need all the information we can, to be able to help. Make sure to at least provide - Current behaviour, Expected behaviour, A way to reproduce the issue with minimal code (link to snack.expo.dev) or a repo on GitHub, and the information about your environment (such as the platform of the device, versions of all the packages etc.). |
Current behaviour
Dialog has rounded corners even if you specify
roundness: 0
in paper theme.Expected behaviour
Dialog to not have rounded corners when roundness is set to zero.
How to reproduce?
Create a theme with roundness set to zero and provide that to PaperProvider. Use time picker inside the provider and see that the corners are rounded.
Preview
What have you tried so far?
This is just wrong in current implementation. Roundness is not even considered.
Your Environment
The text was updated successfully, but these errors were encountered: