Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add Stop to provider interface and differentiate stop & delete #330

Open
richardcase opened this issue Dec 20, 2021 · 4 comments
Open
Labels
kind/feature New feature or request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@richardcase
Copy link
Contributor

Describe the solution you'd like:
With #329 we removed Stop from the Microvm provider interface and form the firecracker implementation as stop isn't used (we currently take action in delete).

We should add Stop back in and update flintlock so that the following happens:

  • Stop stops the microvm from running (i.e. stops firecracker procvess)
  • Delete deletes any files/resources that where created my the provider implementation. So for Firecracker it will be things like firecracker.cfg & metdata.json

Why do you want this feature:

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 19, 2022
@Callisto13 Callisto13 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 23, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 19, 2023
@aryan9600
Copy link
Contributor

aryan9600 commented May 26, 2023

@richardcase After going through what the delete plan looks like atm and the proposal in this issue, I think we should

  • get rid of runtime.deleteDirectory and shift its logic to fcProvider.Delete().
  • shift the current logic in fcProvider.Delete() to fcProvider.Stop().

Then update the deletion plan to replace

  • the step which uses fcProvider.Delete() with a step which uses fcProvider.Stop()
  • the step which uses runtime.deleteDirectory with a step uses fcProvider.Delete()

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 27, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
Status: Backlog
Development

No branches or pull requests

3 participants