Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme for the project? #572

Open
DudhaneShrey86 opened this issue Feb 5, 2023 · 3 comments
Open

Dark theme for the project? #572

DudhaneShrey86 opened this issue Feb 5, 2023 · 3 comments
Labels
feature request New feature or request

Comments

@DudhaneShrey86
Copy link

Describe the new feature you'd like

Is there an existing dark theme for this project? If not I would like to submit a PR with a dark theme.
If there is one, please guide me about how to use it!

@DudhaneShrey86 DudhaneShrey86 added the feature request New feature or request label Feb 5, 2023
@andrew-boyd
Copy link
Member

There is not currently a dark theme — Vue Formulate ships with a basic theme called "snow" out-of-the-box so that users have something to start with but it is not intended in and of itself to be a UI library.

If you want to create a dark theme I'd be happy to take a look at it and once it's complete and well-considered we'd happily link to your theme repo from the official Docs.

https://vueformulate.com/guide/theming/#contributing-themes

@DudhaneShrey86
Copy link
Author

Alright! Thank you for your guidance, I'll get to it ASAP.

@DudhaneShrey86
Copy link
Author

Hey!
While going through the code I found the "danger" buttons are not actually styled correctly.

Current:

Vue.App.mp4

Fixed it as such:

Vue.App.1.mp4

But I am not entirely sure with the colors on that button, looks a little dark to me (have used the default colors of snow).
Cannot invert the colors as it won't match the primary buttons, they go from colored to a little faint color.

$formulate-error: #960505;
The base color is this, and its used mostly to display errors, like one below.

1

Maybe we can bump up the color to a little lighter shade, so that it doesn't effect the error texts too much, but looks a little nicer on the button?

Open to everyone's opinions,
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants