-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a subset of strict: true
in the SDK
#2010
Labels
Comments
strict: true
in the SDK
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Building the SDK generates two kinds of files:
.js
) used in the runtime..d.ts
) used for type support by the IDE.Declaration files (
d.ts
) are subject to our user's tsconfig.json which is more strict than sdk/wasp/tsconfig.json used to build the SDK. This results in the SDK's declaration files having type errors when looked at from the user's perspective (e.g., during go-to-definition jumps).We've avoided using
strict: true
in the tsconfig.json we use for building the SDK due to legacy reasons (old JS or improperly typed code that still works).This is not a big problem, but definitely isn't ideal:
Since the
strict: true
compiler flag is a shorthand for multiple more specific flags, we should activate all the "subflags" that don't require a major refactor of the SDK. After that's done, we can tackle #1938 and change whatever we need to go full strict mode (this will probably take some time).The text was updated successfully, but these errors were encountered: