Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimizing navigation-link-behaviour #99

Open
mindreaderlupo opened this issue Apr 5, 2024 · 1 comment
Open

Optimizing navigation-link-behaviour #99

mindreaderlupo opened this issue Apr 5, 2024 · 1 comment
Assignees
@vincanger

Comments

@mindreaderlupo
Copy link

mindreaderlupo commented Apr 5, 2024 •
edited

AppNavBar.tsx L48
Replace <a href> with <NavLink to> (imported from react-router-dom)

This change makes the pages load quicker and without refreshing everything like an external link.
@aslamahemad aslamahemad mentioned this issue Apr 15, 2024
Closed
@vincanger
Copy link
Collaborator

Would Wasp's Link component (which is a NavLink wrapper) maybe be better for this?

@vincanger vincanger self-assigned this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vincanger vincanger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: optiized navigation-link-behavior aslamahemad/open-saas
2 participants
@vincanger @mindreaderlupo