-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undefined behavior in wasi implementation (and public-facing API is error prone) #457
Comments
Any suggestions on how to fix it? |
we would get rid of
alternatively: instead of getting rid of edit: hmm |
another problem with |
The wasi implementation is full of code like (e.g.)
but this can create UB by blowing past the end of the allocated memory when doing
m3ApiGetArgMem
. Simply blowing past the allocation is enough to make it UB, regardless of the presence ofm3ApiCheckMem
.This entire
m3ApiGetArgMem
API is extremely error-prone.The text was updated successfully, but these errors were encountered: