-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CropCircleWithBorderTransformation - border radius incorrect #186
Comments
Fixed transform function should look like this:
I would create PR myself, but I do not have rights to push, since I am not marked as contributor. |
This was referenced Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
TransformationUtils.circleCrop(...)
is working with minimal edge (Math.min(destWidth, destHeight)
), but CropCircleWithBorderTransformation is drawing border radius using maximal edge.glide-transformations/transformations/src/main/java/jp/wasabeef/glide/transformations/CropCircleWithBorderTransformation.java
Line 73 in 8144929
As a result border is not around image when target width and height are different.
The text was updated successfully, but these errors were encountered: