Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global HotKey is not working #4861

Open
sKawashima opened this issue May 1, 2024 · 7 comments
Open

Global HotKey is not working #4861

sKawashima opened this issue May 1, 2024 · 7 comments
Labels
Bugs Bugs, Hangs, Crash, and Freezes

Comments

@sKawashima
Copy link

sKawashima commented May 1, 2024

Discord username (optional)

No response

Describe the bug

Setting Keybinding to Show/Hide all windows in Global HotKey is not reflected.

To reproduce

OS accessibility settings on MacOS 14.3 (23D56).
Occurs on Warp v0.2024.04.23.08.01.stable_03.
Key layout is US layout.
I have ⌥Enter set, but changing to something else did not work.
Restarted OS but no change.

Expected behavior

Setting Keybinding to Show/Hide all windows in Global HotKey is not reflected.

Screenshots

No response

Operating system

MacOS

Operating system and version

Sonoma 14.3

Shell Version

No response

Current Warp version

No response

Regression

No, this bug or issue has existed throughout my experience using Warp

Recent working Warp date

No response

Additional context

No response

Does this block you from using Warp daily?

Yes, this issue prevents me from using Warp daily.

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

No, this same issue happens in Warp and other terminals.

Warp Internal (ignore): linear-label:b9d78064-c89e-4973-b153-5178a31ee54e

None

@sKawashima sKawashima added the Bugs Bugs, Hangs, Crash, and Freezes label May 1, 2024
@acarl005
Copy link

acarl005 commented May 2, 2024

Hi @sKawashima thanks for reporting. I'm looking at your reproduction steps.

"OS accessibility settings on MacOS 14.3 (23D56)"

Can you explain this a bit more? Which settings do you mean? Are you using the accessibility keyboard?

Screenshot 2024-05-02 at 06 56 36

@sKawashima
Copy link
Author

sKawashima commented May 2, 2024

Thanks for the response,@acarl005.

Sorry for the lack of explanation.
I was referring to the System Preferences > Security & Privacy > Accessibility setting shown in the Troubleshooting Hotkey Dedicated Window section.

@acarl005
Copy link

acarl005 commented May 2, 2024

Ah I see. Can you run the following commands and post their output?

defaults read dev.warp.Warp-Stable ActivationHotkeyEnabled
defaults read dev.warp.Warp-Stable ActivationHotkeyKeybinding

@sKawashima
Copy link
Author

I tried.
Is this correct?

defaults read dev.warp.Warp-Stable ActivationHotkeyEnabled
defaults read dev.warp.Warp-Stable ActivationHotkeyKeybinding
true
{"ctrl":false,"alt":true,"shift":false,"cmd":false,"meta":false,"key":"enter"}

@acarl005
Copy link

acarl005 commented May 3, 2024

Ok that looks good. Can I clarify what exactly happens when you press ⌥Enter? Do Warp windows just remain visible when they should be hiding themselves?

I have a couple more things I'd like to verify. Can you run this command as well?

defaults read dev.warp.Warp-Dev ExtraMetaKeys

I see your keyboard has the US layout. Can you also tell me what input source you have configured in your settings?

Screenshot 2024-05-03 at 11 24 14

@sKawashima
Copy link
Author

sKawashima commented May 5, 2024

Thank you.
Nothing happens when I press ⌥Enter.
The window doesn't hide, nor does it focus on the window.

The command you gave me can be executed, but I am getting an error.

defaults read dev.warp.Warp-Dev ExtraMetaKeys
2024-05-05 17:44:25.922 defaults[60443:7524593]
The domain/default pair of (dev.warp.Warp-Dev, ExtraMetaKeys) does not exist

I use "Google IME" as my input source.
I use this for both Japanese and English input.
スクリーンショット 2024-05-05 17 49 21

@acarl005
Copy link

acarl005 commented May 6, 2024

Thanks for all the information! I think this is a problem recognizing shortcuts correctly for japanese input. We'll take a look at our keybinding code for international users. Related to #341

@warpdotdev-devx warpdotdev-devx bot reopened this May 6, 2024
@acarl005 acarl005 reopened this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugs Bugs, Hangs, Crash, and Freezes
Projects
None yet
Development

No branches or pull requests

2 participants