Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Documentation for Integrated Magepack Support #168

Open
davidalger opened this issue Jun 20, 2020 · 6 comments
Open

Create Documentation for Integrated Magepack Support #168

davidalger opened this issue Jun 20, 2020 · 6 comments
Labels
documentation up for grabs Extra attention is needed
Milestone

Comments

@davidalger
Copy link
Collaborator

A quality PR from @vbuck added support integrated Magepack support via an additional WARDEN_MAGEPACK setting in the .env file for magento2 projects. This integration and how to use it is covered fairly well on the PR, but needs a documentation page. For information on Magepack and to learn more about the advanced JS bundling it does go here: https://github.com/magesuite/magepack and for information on how to use the integrated Magepack support, take a look at the details provided on PR #138

@davidalger davidalger added up for grabs Extra attention is needed documentation labels Jun 20, 2020
@Lunaetic
Copy link
Contributor

Lunaetic commented Jun 22, 2020

I've started on a branch for this task, but likely won't be able to complete until towards the end of the week - just a heads up. (As I want to do a bit of testing with regards to Magepack.)

@ihor-sviziev
Copy link
Contributor

@Lunaetic do you have any updates on testing magepack?
Could you create a PR, so we'll be able to check your suggested changes?

@stale
Copy link

stale bot commented Dec 12, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Dec 12, 2020
@ihor-sviziev
Copy link
Contributor

@Lunaetic any updates on creating PR for the covering magepack integration with some docs?

@stale stale bot closed this as completed Dec 19, 2020
@davidalger davidalger reopened this Dec 21, 2020
@stale stale bot removed the stale label Dec 21, 2020
@virtuman
Copy link

Has anyone figured out how to set it up? Super curious to see it in action. I would gladly add PR for appropriate documentation, if someone could give pointers on how to activate. Thank you.

@ihor-sviziev
Copy link
Contributor

@virtuman all details described in the PR and comments #138

@navarr navarr added this to the Warden 1.0.0 milestone Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation up for grabs Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants