Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runner Logging level does not affect logs output #360

Open
nbarabash opened this issue Mar 15, 2021 · 2 comments
Open

Runner Logging level does not affect logs output #360

nbarabash opened this issue Mar 15, 2021 · 2 comments
Labels
docs question Further information is requested

Comments

@nbarabash
Copy link

Runner logging level is set as "WARN", but the logs is full of "INFO" level messages.

configuration:
runner:
logLevel: "WARN"

Logs:

09:55:42 [INFO ] Storing policy '[concord-base, default-variables]' data
09:55:42 [INFO ] Copying the repository's data: https://.........
feature/ssl-offset-reset:head, path: /kafka-offset-reset-service
09:55:43 [INFO ] Using entry point: startResetOffset
09:55:43 [INFO ] Applying policies...
09:55:43 [INFO ] Storing default dependency versions...
09:55:43 [INFO ] Enqueued. Waiting for an agent (requirements={agent={flavor=large}})...
09:55:44 [INFO ] Acquired by: Concord-Agent: id: ff119787-3336-5687-8df2-e0d27e738a68 /devtools/concord-prod0/prod0/bom/agent-large-cent76/1 @ p
09:55:44 [INFO ] Exporting the repository data: ....... @ feature/ssl-offset-reset:0dd9b935ef01acdb851cc1c7a469f7d3c4e1fb7e, path: /kafka-offset-reset-service
09:55:45 [INFO ] Repository data export took 509ms
09:55:45 [INFO ] Downloading the process state...
09:55:45 [INFO ] Process state download took 58ms
09:55:45 [INFO ] Runtime: concord-v1
09:55:45 [INFO ] Resolving process dependencies...
09:55:45 [INFO ] Checking the dependency policy...
09:55:45 [INFO ] Dependencies:
mvn://com.walmartlabs.concord.plugins.basic:concord-tasks:1.79.1
mvn://com.walmartlabs.concord.plugins.basic:slack-tasks:1.79.1
mvn://com.walmartlabs.concord.plugins.basic:http-tasks:1.79.1
09:55:52 [INFO ] Process status: RUNNING
09:55:53 [INFO ] Process finished with: 0

@ibodrov ibodrov added the docs label Mar 16, 2021
@ibodrov
Copy link
Collaborator

ibodrov commented Mar 16, 2021

Docs need to clarify that configuration.runner.logLevel affects only the process' own logs and not server or agent logs.
Unless there's a specific use case to hide all "system" INFOs too, @nbarabash?

@ibodrov ibodrov added the question Further information is requested label Mar 16, 2021
@nbarabash
Copy link
Author

nbarabash commented Mar 16, 2021

few cases here

  1. Minimize logs
  2. Avoid printing sensitive info - Input values passed form the form/UI and later delegated to docker or sh script are printed in the logs. However some of them may be secrets and should not be printed in logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs question Further information is requested
Development

No branches or pull requests

2 participants