Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: 提供 Event 监听触发 #1982

Open
jerryc127 opened this issue May 20, 2023 · 5 comments · May be fixed by #2136
Open

[Feature]: 提供 Event 监听触发 #1982

jerryc127 opened this issue May 20, 2023 · 5 comments · May be fixed by #2136
Labels
discussion Question or dicussion enhancement New feature or request Inactive

Comments

@jerryc127
Copy link
Contributor

功能概述 | Describe the feature

waline 是否有兴趣提供 event 触发
类似于 artalk 这样

https://artalk.js.org/develop/event.html
image

@jerryc127 jerryc127 added discussion Question or dicussion enhancement New feature or request labels May 20, 2023
@lizheming
Copy link
Collaborator

lizheming commented May 30, 2023

可以先说下你需要实现什么功能?


Can you tell me what function you need to achieve?

@jerryc127
Copy link
Contributor Author

jerryc127 commented Jun 1, 2023

就比如說
提供一個評論列表加載完成后的調用,這樣可以處理大圖點擊效果/或者可能有需要提醒用戶評論加載完成等等
點擊下一頁或者滾動時,有新的評論插入,就可以調用


for example
Provide a call after the comment list is loaded, which can handle the click effect of the large image/or may need to remind the user that the comment loading is complete, etc.
When clicking on the next page or scrolling, if there is a new comment inserted, you can call

@lizheming
Copy link
Collaborator

lizheming commented Jun 2, 2023

  1. 图片大图效果可以看文档 https://waline.js.org/cookbook/customize/image-preview.html
  2. 评论加载完成提醒这个感觉是伪需求 @Mister-Hope 可以帮忙一块判断下
  3. 「点击下一页或者滚动时有新的评论插入可以调用」调用了之后想干什么呢?@jerryc127

  1. For the big image effect, please refer to the document https://waline.js.org/cookbook/customize/image-preview.html
  2. Remind that the comments are loaded and this feels like a false demand @Mister-Hope can help you make a judgment
  3. What do you want to do after "clicking on the next page or scrolling to insert new comments that can be called"? @jerryc127

@Mister-Hope
Copy link
Member

Mister-Hope commented Jun 2, 2023

暴露事件是合理的,v2会提供,不过目前我还在摇摆使用vue还是提供一个custom-component


It is reasonable to expose events, and v2 will provide them, but I am still swinging to use vue or provide a custom-component

@Mister-Hope Mister-Hope linked a pull request Oct 31, 2023 that will close this issue
@Mister-Hope
Copy link
Member

It's hard to expose an internal component event outside vue application, I will find a way which is not hacky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Question or dicussion enhancement New feature or request Inactive
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants