Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Layers are does not scroll #494

Open
glensc opened this issue Jan 16, 2024 · 4 comments · May be fixed by NixOS/nixpkgs#311901
Open

Bug: Layers are does not scroll #494

glensc opened this issue Jan 16, 2024 · 4 comments · May be fixed by NixOS/nixpkgs#311901
Labels
bug Something isn't working

Comments

@glensc
Copy link

glensc commented Jan 16, 2024

What happened:

Trying to inspect image with more than 10 layers got me confused where are the other layers. Seems that the arrow down moves to next item, but it's not visible because it's out of the layers window which is 10 rows of height

What you expected to happen:

The layers window should scroll if selected item moves out of focus

How to reproduce it (as minimally and precisely as possible):

  1. Find a image with more than 10 layers
  2. Run dive on it, example: dive php:7.2-fpm
  3. Try to move to 11th layer by pressing down arrow

Example:

This can be avoided by using smaller font, i.e. larger display

Anything else we need to know?:

Environment:

  • OS version
  • Docker version (if applicable)
@glensc glensc added the bug Something isn't working label Jan 16, 2024
@mark2185
Copy link
Contributor

It's a known issue, please try building this PR from source, should fix it.

@danilo-lopes
Copy link

@mark2185 I tried to use the PR with Docker version 4.28.0 (139021) and doesn't work. I and don't know which Docker version is supposed to work.

dive ➤ go run main.go gcr.io/distroless/java11-debian11:latest                                 git:fix/scrolling-contents
Image Source: docker://gcr.io/distroless/java11-debian11:latest
Fetching image... (this can take a while for large images)
cannot fetch image
could not find image config
exit status 1

Tried to use latest Dive version but can't scrolling through the image layers

st-gr added a commit to st-gr/dive that referenced this issue May 10, 2024
@st-gr
Copy link

st-gr commented May 10, 2024

I had the same issue trying to wade through a 40 GB image with too many layers. I fixed the scrolling in the layers view with above commit.

@GuillaumeDesforges GuillaumeDesforges linked a pull request May 15, 2024 that will close this issue
13 tasks
@ulexxander
Copy link

Does not work on 0.12 for me too. But works on 0.10 curl -LO https://github.com/wagoodman/dive/releases/download/v0.10.0/dive_0.10.0_linux_amd64.tar.gz

But it would be nice if it's fixed in the newer version, really annoying :(

Fantastic software anyway, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants