Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EncodedAudioChunkInit should probably also support AllowSharedBufferSource #788

Closed
chrisguttandin opened this issue May 16, 2024 · 1 comment
Closed

EncodedAudioChunkInit should probably also support AllowSharedBufferSource #788

chrisguttandin opened this issue May 16, 2024 · 1 comment
Assignees
@Djuffin
Labels
editorial changes to wording, grammar, etc that don't modify the intended behavior

Comments

@chrisguttandin
Copy link
Contributor

I've noticed that the data of a EncodedVideoChunkInit object is of type AllowSharedBufferSource while the data of a EncodedAudioChunkInit object can only be of type BufferSource.

https://w3c.github.io/webcodecs/#dictdef-encodedvideochunkinit
https://w3c.github.io/webcodecs/#dictdef-encodedaudiochunkinit

It looks like EncodedVideoChunkInit was changed to align it with a WPT in #575 / #576. But a similar WPT with a SharedArrayBuffer also exists for EncodedAudioChunkInit and all browsers seem to pass it.

https://wpt.fyi/results/webcodecs/encoded-video-chunk.crossOriginIsolated.https.any.html?label=experimental&label=master&aligned
https://wpt.fyi/results/webcodecs/encoded-audio-chunk.crossOriginIsolated.https.any.html?label=master&label=experimental&aligned
@Djuffin Djuffin self-assigned this May 17, 2024
@Djuffin Djuffin added the editorial changes to wording, grammar, etc that don't modify the intended behavior label May 17, 2024
Djuffin added a commit that referenced this issue May 17, 2024
@Djuffin
Change type of EncodedVideoChunkInit.data to AllowSharedBufferSource
e24df65 
Addressing: #788
@Djuffin Djuffin mentioned this issue May 17, 2024
Merged
padenot pushed a commit that referenced this issue May 20, 2024
@Djuffin @padenot
Change type of EncodedVideoChunkInit.data to AllowSharedBufferSource
485f58e 
Addressing: #788
@padenot
Copy link
Collaborator

padenot commented May 20, 2024

Fixed, closing.

@padenot padenot closed this as completed May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Djuffin Djuffin

Labels
editorial changes to wording, grammar, etc that don't modify the intended behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Djuffin @chrisguttandin @padenot