Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Options in the Admin's AssignTesterDropdown incorrectly including checked and not checked in the option name instead of using aria-checked #977

Closed
howard-e opened this issue Mar 21, 2024 · 0 comments
Closed

Options in the Admin's AssignTesterDropdown incorrectly including checked and not checked in the option name instead of using aria-checked #977

howard-e opened this issue Mar 21, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@howard-e
Copy link
Contributor

howard-e commented Mar 21, 2024 •
edited by ccanash

Stated in a recent CG discussion, the tester options in the AssignTesterDropdown are incorrectly stating checked or not checked in the tester option text.

Ideally the selected options should be making use of aria-checked to convey this state.
@howard-e howard-e added the bug Something isn't working label Mar 21, 2024
@mcking65 mcking65 changed the title Admin's AssignTesterDropdown incorrectly stating checked and not checked for the tester options Options in the Admin's AssignTesterDropdown incorrectly including checked and not checked in the option name instead of using aria-checked Mar 25, 2024
@evmiguel evmiguel mentioned this issue May 16, 2024
Merged
howard-e pushed a commit that referenced this issue May 20, 2024
@evmiguel
fix: Use aria-checked for AssignTesterDropdown (#1097)
ae97530 
Address #977 

* Use aria-checked for `AssignTesterDropdown`
* Update dropdown item role to `menuitemcheckbox` and remove `aria-hidden` from username
@howard-e howard-e mentioned this issue May 28, 2024
Merged
howard-e added a commit that referenced this issue May 28, 2024
@howard-e @alflennik
@Paul-Clue @gnarf @evmiguel @jugglinmike
Merge pull request #1112 from w3c/development
9f5ada4 
Issues addressed:
* #1105, addresses w3c/aria-at#1070
* #1053, addresses w3c/aria-practices#2971
* #1097, addresses #977
* #1095, addresses #991
* #1093, addresses #934
* #1000, addresses #818
* #1089, addresses #992
* #1067, addresses #993
* #1056, addresses w3c/wai-aria-practices#212

---------

Co-authored-by: alflennik <[email protected]>
Co-authored-by: Paul Clue <[email protected]>
Co-authored-by: Mx Corey Frang <[email protected]>
Co-authored-by: Mx. Corey Frang <[email protected]>
Co-authored-by: Erika Miguel <[email protected]>
Co-authored-by: Mike Pennisi <[email protected]>
@ccanash ccanash closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@howard-e @ccanash