-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report errors from subprocesses #957
Comments
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While investigating an issue with this project's "import" script, @howard-e found that a process spawned by the script had crashed. Although this exceptional circumstance should be plainly evident from server logs, Howard could only intuit its occurrence indirectly (that is: by interpreting an error which occurred after the script incorrectly assumed the subprocess had exited cleanly).
Whenever a subprocess is created, the parent should account for the possibility that the child does not complete successfully (even if it is only to report the failure and exit).
A cursory review of the source identifies a number of instances of hazardous subprocess management:
...so addressing this problem should begin with a formal audit of the project.
The text was updated successfully, but these errors were encountered: