Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset temporal denoiser state on significant changes #661

Open
w23 opened this issue Nov 21, 2023 · 1 comment
Open

Reset temporal denoiser state on significant changes #661

w23 opened this issue Nov 21, 2023 · 1 comment
Labels
bug Something isn't working denoiser ray tracing visual bug Visual glitches, something looks incorrectly

Comments

@w23
Copy link
Owner

w23 commented Nov 21, 2023 •
edited

Temporal denoiser should be cleared on any spatial discontinuities:

  • map change
  • load
  • teleport
  • what else?

Mostly affects reproducible rendering regression testing
@w23 w23 added bug Something isn't working ray tracing visual bug Visual glitches, something looks incorrectly denoiser labels Nov 21, 2023
w23 added a commit that referenced this issue Dec 19, 2023
@w23
rt: try to clear temporal buffers on discontinuities once more
239d7bc 
Found out that it wasn't really clearing anything.
Now it does call clear, but still there are temporal denoising
artifacts. The issue remains elusive.

Related: #661
@w23
Copy link
Owner Author

w23 commented Jan 8, 2024

Still isn't done. All previous attempts failed so far for yet unknown reason.
It might be the case that current ad-hoc g-buffer texture tracking is lacking, and a more proper per-object (almost-rendergraph) kind of tracking is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working denoiser ray tracing visual bug Visual glitches, something looks incorrectly
Projects
HLRT
Status: 🔖 Ready
Milestone
No milestone
Development

No branches or pull requests
1 participant
@w23