Skip to content
This repository has been archived by the owner on Jun 27, 2022. It is now read-only.

Cipher Deletion Route #80

Open
overholts opened this issue Jul 23, 2020 · 1 comment
Open

Cipher Deletion Route #80

overholts opened this issue Jul 23, 2020 · 1 comment

Comments

@overholts
Copy link

This implementation hosts cipher deletion at DELETE /api/ciphers/{uuid} but the Bitwarden client (at least, latest Firefox extension version 1.45.0 and seemingly the iOS app) makes the request to PUT /api/ciphers/{uuid}/delete which results in a 404 from API Gateway.

I haven't done enough digging to determine whether this is a change made in Bitwarden or it's always been like this but I assume the former based on this test case. Might look into mapping the newer route when I get back from vacation, but this is admittedly not a frequently used bit of functionality.

Repro Steps

Try to delete a vault entry using the latest Firefox extension. Network inspector for the Bitwarden extension:

broken

Cloning the request with /delete removed from the URI and changing the method to DELETE works as expected:

fixed

@overholts
Copy link
Author

Looks like the official server supports POST routes for all PUT/DELETE operations: bitwarden/server@54696aa

Commit likely related to recent change in client behavior: bitwarden/jslib@19668ab

Plan to add the additional routes to serverless.yml when I get a chance to go through them all.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant