-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency in Custom Containers use of Color Functions #3893
Labels
theme
Related to the theme
Comments
brc-dd
added
theme
Related to the theme
and removed
bug: pending triage
Maybe a bug, waiting for confirmation
labels
May 18, 2024
|
I'm happy to send to send a PR to do some clean up work here if you want. |
Ah, please wait. I'll take this one. That part of CSS variables wasn't meant to be used like that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When trying to adapt the color schemes of Custom Container's I noticed a slight inconsistency in how color functions are used, which led to some initial confusion.
The
vars.css
defined colors for various type, liketip
,note
,warning
, etc.. These colors are (for the most part) used in the corresponding Custom Container's as well.For example, as a user if I wish to have all tips (including Custom Containers) appear in green, I can set
However, if I wish to achieve the same for either Notes or Info, this doesn't work. As Note and Info Customer Containers are "hardcoded" to
default
in
vars.css
.Reproduction
Try to make a Note Custom Container
indigo
:But still, Note Customer container will be Gray.
Expected behavior
Setting
should make all notes (including Custom Containers) appear in indigo.
As a workaround users can additionally set
However, I would expect to be only required to change the
--vp-custom-block-note-*
CSS variables if I want Note Custom Containers to be different from other Notes.System Info
Additional context
No response
Validations
The text was updated successfully, but these errors were encountered: