Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sympy dependency #586

Closed
vprusso opened this issue May 16, 2024 · 2 comments
Closed

Remove sympy dependency #586

vprusso opened this issue May 16, 2024 · 2 comments

Comments

@vprusso
Copy link
Owner

vprusso commented May 16, 2024

As sympy is a required install but only used for one function, it might be ideal to use another non-sympy approach to reduce the need to require sympy as a dependency.

from sympy import isprime, primerange

We could then remove the dependency from the toml file:

sympy = "1.12"

and from the requirements:

sympy == 1.12

@purva-thakre
Copy link
Collaborator

Based on what I could find, we can use numpy for primerange. But I couldn't find a convenient substitute for isprime unless you are thinking of defining our own function for this.

It might be easier to keep sympy as a dependency instead.

@vprusso
Copy link
Owner Author

vprusso commented Jun 24, 2024

As you mentioned, @purva-thakre , I think either I would need to handroll the solution or use another third party package. For now, let's keep the dependency as you suggested. Closing for now.

@vprusso vprusso closed this as completed Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants