Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change comparison function to return :lt, :gt, :eq instead of -1, 1, 0 #4

Open
vorce opened this issue Mar 28, 2018 · 0 comments
Open

Change comparison function to return :lt, :gt, :eq instead of -1, 1, 0 #4

vorce opened this issue Mar 28, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@vorce
Copy link
Owner

vorce commented Mar 28, 2018 •
edited

It's how NaiveDateTime.compare works for example.

dasie/lib/red_black_tree.ex

Line 49 in 003fde9

@spec member?(node :: __MODULE__.t(), element :: any, compare_fn :: function) :: boolean

Should also document it better :)
@vorce vorce added the enhancement New feature or request label Mar 28, 2018
@vorce vorce added the question Further information is requested label May 7, 2019
@vorce vorce removed the question Further information is requested label Apr 29, 2021
@vorce vorce changed the title Should comparison function return :lt, :gt, :eq instead? Change comparison function to return :lt, :gt, :eq instead of -1, 1, 0 Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vorce