Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Material 3+You. #464

Open
RokeJulianLockhart opened this issue Apr 20, 2024 · 2 comments
Open

Support Material 3+You. #464

RokeJulianLockhart opened this issue Apr 20, 2024 · 2 comments
Labels
needinfo Further information is requested

Comments

@RokeJulianLockhart
Copy link

RokeJulianLockhart commented Apr 20, 2024

Reproducer steps

  1. Install CalyxOS Android 14.
  2. Install https://github.com/vmiklos/plees-tracker/releases/download/v24.2.2/app-release.apk.

Actual result

Each Material 2 GUI component is styled manually and independently from the system. Most prominently, the title bar.

Expected behavior

I expected it to adhere to https://m3.material.io/styles/color/dynamic/user-generated-source.

Additional information

Additional rationale is available at QuickLyric/QuickLyric#271 (comment).

@vmiklos
Copy link
Owner

vmiklos commented Apr 20, 2024

Are you interested in looking at this yourself?

Also, are you aware of some other open-source Android app that has a title bar color depending on the wallpaper of the user? It would be good to see what APIs or configs they use to have this. Also to see if they do this by default or if this is opt-in. Keeping the default unchanged always makes me feel safer.

My first thought is that I'm not particularly interested in this (dark mode in itself is already a bit painful), but if somebody does the work, I don't mind. :-) Thanks.

@vmiklos vmiklos added the needinfo Further information is requested label Apr 20, 2024
@RokeJulianLockhart RokeJulianLockhart changed the title Material 3+You Support Material 3+You. Apr 21, 2024
@RokeJulianLockhart
Copy link
Author

RokeJulianLockhart commented Apr 21, 2024

#464 (comment)

@vmiklos, defaults indeed are usually best. I'm not an Android developer, so I assumed that M3 would be the new default for any major Android GUI framework. However, I recall that something similar was stated at Divested-Mobile/Hypatia#57 (comment). Regardless, https://github.com/AChep/keyguard-app/blob/c1fce0227ede567a62601dc44b94f9a9f8639c51/README.md#looks is a good example of what I'm referring to. As depicted, headings for M3 significantly differ to M2. Specifically, if I use a window manager as an analogy, they are more like CSD than SSD, yet remain visually consistent overall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needinfo Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants