-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow setting star ratings from overview #454
Comments
Yes, this is indeed a problem. The trouble is that it seems the intention is that no interactive items are included in an item of a recycler view, which goes against the idea of interacting with the rating there. See #161, do you have an idea how to do what you want in a way that doesn't re-introduce that issue? |
Sorry I have no understanding of how recycler view works. If this is a limitation, setting stars on that view probably won't be feasible. From a UX standpoint, preventing a reintroduction of #161 seems feasible via two mechanisms:
Wondering how other Android apps handle star ratings. I had a glance at my installed apps but none used star ratings. Probalby the commercial sleep trackers do. But then again those are not open source so can't be inspected easily as to how their implementation works. |
Reproducer steps
Actual result
... a separate page opens.
Expected behavior
... opening a separate page really isn't needed and complicates the interaction unnecessarily. It would be easier if setting the star rating was possible from the Past sleeps overview page.
The text was updated successfully, but these errors were encountered: