Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting star ratings from overview #454

Open
foss- opened this issue Mar 10, 2024 · 2 comments
Open

allow setting star ratings from overview #454

foss- opened this issue Mar 10, 2024 · 2 comments
Labels
needinfo Further information is requested

Comments

@foss-
Copy link

foss- commented Mar 10, 2024

Reproducer steps

  1. when on overview page and looking to set a star rating for a certain night in the past sleeps listing, when tapping the stars...

Actual result
... a separate page opens.

Expected behavior
... opening a separate page really isn't needed and complicates the interaction unnecessarily. It would be easier if setting the star rating was possible from the Past sleeps overview page.

@vmiklos
Copy link
Owner

vmiklos commented Mar 14, 2024

Yes, this is indeed a problem. The trouble is that it seems the intention is that no interactive items are included in an item of a recycler view, which goes against the idea of interacting with the rating there.

See #161, do you have an idea how to do what you want in a way that doesn't re-introduce that issue?

@vmiklos vmiklos added the needinfo Further information is requested label Mar 14, 2024
@foss-
Copy link
Author

foss- commented Mar 17, 2024

Sorry I have no understanding of how recycler view works. If this is a limitation, setting stars on that view probably won't be feasible.

From a UX standpoint, preventing a reintroduction of #161 seems feasible via two mechanisms:

  • make setting the star rating require a long-press (unsure if scrolling, the finger remains on the UI element but it moves counts as long press - intuitively I'd say no, but needs to be verified. Only after long-pressing initiate the UI to set / change star rating by switching the long-press into swipe gesture)
    or
  • when tapping the stars show an overlay that requires additional interaction to set the star rating (this could work in a way, that if no further interaction is done, e.g. when intending to scroll, the overlay automatically closes once the user lifts their finger. Setting a star rating could require an additional lift of the finger and additional tap on the star rating in the overlay)

Wondering how other Android apps handle star ratings. I had a glance at my installed apps but none used star ratings. Probalby the commercial sleep trackers do. But then again those are not open source so can't be inspected easily as to how their implementation works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needinfo Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants