Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Is it possible to dynamically adjust lora tp policy to different situations ? #4704

Open
yyccli opened this issue May 9, 2024 · 0 comments

Comments

@yyccli
Copy link

yyccli commented May 9, 2024

馃殌 The feature, motivation and pitch

Thanks to the Full TP LoRA pr, now we can use S-LoRA's TP policy. However, this TP strategy provides some performance gains in the case of long prefills, while almost certainly introducing additional latency in the decode stage due to the new communication operation.
Here is some profiling results, i test qwen1.5 14b with one LoRA model
image
In this case, i test an end-to-end performance of long prefill + short decode
image
Typically, we'll usually have a long prefill, but not always get a short decode every time
So... is it possible to apply Full TP when prefill and Partial TP when decode?

Alternatives

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant