Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to max selections #313

Open
vlio20 opened this issue Dec 14, 2017 · 7 comments
Open

Option to max selections #313

vlio20 opened this issue Dec 14, 2017 · 7 comments

Comments

@vlio20
Copy link
Owner

vlio20 commented Dec 14, 2017

In multi select mode it would be great to have maximum selections.
When selecting more than the allowed number the first selection will be unselected

@vlio20 vlio20 added this to the 2.7.0 milestone Dec 21, 2017
@vlio20 vlio20 removed this from the 2.7.0 milestone Jan 6, 2018
@justtal
Copy link
Contributor

justtal commented Jan 13, 2018

I'll take it.

Does new config maxSelections for day picker and month picker sounds good?

I think that the best behaviour is when choosing max selections to disable more selections until removing a selection.

@vlio20
Copy link
Owner Author

vlio20 commented Jan 13, 2018

the naming is ok. Regarding the behaviour, in my opinion there are 2 options:

  1. (as described by you) disable more selections until removing a selection
  2. Unselect the oldest when max exceeded.

I prefer the second, lets start with it? we later can add configuration to achieve the first. WDYT?

@vlio20 vlio20 added this to the 2.8.0 milestone Jan 13, 2018
@vlio20 vlio20 modified the milestones: 2.8.0, 2.9.0, Backlog Mar 6, 2018
@avineet1993
Copy link

Hi ,
I couldnot able to sepeerate the multi select by comma(',').It is still showing ('|').how to implement that.

config: IDatePickerConfig = {

allowMultiSelect: true,
closeOnSelect: undefined,
closeOnSelectDelay: 100,
openOnFocus: true,
openOnClick: true,
onOpenDelay: 0,
weekDayFormat: 'ddd',

// appendTo: document.body,
showNearMonthDays: true,
showWeekNumbers: false,
inputElementContainer:undefined,
appendTo:undefined,
returnedValueType:ECalendarValue.String
};

placeholder="Select date"> </dp-date-picker> </div>

@vlio20
Copy link
Owner Author

vlio20 commented Apr 30, 2018

@avineet1993 , the separator is set to be '|'. There is no way (currently to change it).

@vlio20
Copy link
Owner Author

vlio20 commented Nov 20, 2020

@justtal I am still waiting :)

@justtal
Copy link
Contributor

justtal commented Nov 20, 2020

Sorry, I'm Reacting already 🤣 😘

@vlio20
Copy link
Owner Author

vlio20 commented Nov 20, 2020

@justtal this is a step in the wrong direction :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants