-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra arguments are not parsed correctly #135
Comments
The problem seems to be in the way that |
No, in fact the problem is that the fix (https://github.com/vlaci/openconnect-sso/blame/master/openconnect_sso/cli.py#L125) is not in Pypi yet. So, released version 0.8.1 is broken because of this line:
|
If you could check if the latest git master is working, I'll release it |
I'll check it out as soon as I have a moment, thanks. |
Yes master is working (note I only tested this specific thing). |
@vlaci released? |
I confirm that by manually chaning openconnect-sso --user [email protected] --server example.io -- -V --script='vpn-slice example.io' |
When using extra arguments to openconnect (ie those after
--
), depending on the syntax used an error might be produced, or the results might be unexpected.For example:
(note the missing
=
in the--script
argument, which is legal syntax) the followingopenconnect
invocation is produced:which openconnect rejects with
Too many arguments on command line
.On the other hand, if using the following syntax (also legal):
(ie with
--script=...
)The resulting
openconnect
invocation iswhich is valid openconnect syntax, but now the extra option is not passed at all, and indeed the custom script is not executed.
The text was updated successfully, but these errors were encountered: