Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test fail #16667

Merged
merged 14 commits into from
May 13, 2024
Merged

test: fix flaky test fail #16667

merged 14 commits into from
May 13, 2024

Conversation

sapphi-red
Copy link
Member

@stackblitz StackBlitz
Copy link

stackblitz bot commented May 13, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label May 13, 2024
patak-dev
patak-dev approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much sapphi 🥲

@patak-dev patak-dev merged commit 65eb48f into vitejs:main May 13, 2024
11 checks passed
@sapphi-red sapphi-red deleted the fix/debug-flaky-fail branch May 13, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sapphi-red @patak-dev