Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenFOAM reader needs updating #19528

Open
biagas opened this issue May 17, 2024 · 0 comments
Open

OpenFOAM reader needs updating #19528

biagas opened this issue May 17, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@biagas
Copy link
Contributor

biagas commented May 17, 2024

Is your feature request related to a problem?

The vtk files in the OpenFOAM reader are based off VTK's, but are much older and VTK has made a number of improvements.

We should investigate if it is feasible to subclass their readers at this point in time.

Part of the reason for the current state of things was the need to make the Point/Face/CellZones names available to the avt portion of the reader for filling in DatabaseMetaData information. They are used to create new meshes (boundary meshes, I believe).

Logic was added to the 'Private' class function MakeMetaDataAtTimeStep of the vtk reader to prevent needing to reread the entire file again.
Logic was also added to GetFieldNames (also in the 'Private' classs) to save LagrangianArrayClassName as they were encountered.
I think the fact that these are part of the 'private' class within the reader made subclassing unworkable.

Describe the solution you'd like.

It would be nice to utilize the VTK reader by subclassing, in order to stay up-to-date, or to do away with use of VTK for this reader at all and implement our own.

@biagas biagas added the enhancement New feature or request label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant