Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hash change = 404 #564

Open
dm-de opened this issue May 1, 2020 · 3 comments
Open

hash change = 404 #564

dm-de opened this issue May 1, 2020 · 3 comments

Comments

@dm-de
Copy link

dm-de commented May 1, 2020

hashbang mode is broken
it do not accept valid changes and return '*' route

output context object:

​canonicalPath: "/#!/user/100"
​hash: ""
​page: Object { current: "//user/100", len: 2, _decodeURLComponents: true, … }
​params: Object { 0: "//user/100", path: "/#!/user/100", query: "" }
​path: "//user/100"
​pathname: "/#!/user/100"
​querystring: ""
​routePath: "(.*)"
​state: Object { path: "/#!/user/100" }
​title: "app"
​: Object { pushState: pushState(), save: save(), … }

As you can see - here is double slash at path - so it can never be correct after hash change - and only '*' ist valid

I was able to fix this:
@ function Context(path, state, pageInstance)

if (hashbang) this.path = this.path.replace('#!', '') || '/';
change to:
if (hashbang) this.path = this.path.replace('/#!', '') || '/';

But i do not know if this has other sideeffects

@mset
Copy link

mset commented May 29, 2020

I have come across the same issue.

@mattfysh
Copy link

😞 🐼

@lagden
Copy link

lagden commented Feb 14, 2021

Do it:

page('/', () => {
	page.redirect('/page/1')
})
page('/notfound', console.log)
page('/page/:number', console.log)
page('*', ctx => {
	if (/^(\/\/)/.test(ctx.path)) {
		page.redirect(ctx.path.slice(1, ctx.path.length))
	} else {
		page.show('/notfound')
	}
})
page.start({hashbang: true})

That workaround avoid the problem!
If you try set the URL via external link or using navigator address bar, will work!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants