-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation skipped #177
Comments
zhizhuxialiwen
pushed a commit
to zhizhuxialiwen/node-progress
that referenced
this issue
Dec 11, 2020
The input `:total` value is float, but the output `:current` value is more than `:total` value. The input `:total` is nagative integer or zero, but the output rendering failed. Closes visionmedia#177, visionmedia#166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On this line of code there's validation for fmt to be a string:
node-progress/lib/node-progress.js
Line 54 in 30d70d9
But if the second argument, passed to constructor, is a number (total), this validation is skipped and, later on, the rendering fails.
The text was updated successfully, but these errors were encountered: