-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Abort signal in loadOptions not working with ScenegraphLayer #2541
Comments
ScenegraphLayer is a deck.gl concept. We need to reformulate this task in terms of Also, it looks like there is a pending fix for the above exception thrown by deck.gl ScenegraphLayer (which happens when it wraps the actual error with extra information). It would be good to understand what the actual error was (either by checking it in the debugger or rerunning the code when the pending fix is published) |
@belom88 are you able to check if we are passing loadOptions through to the GLTFLoader sub-loaders? Specifically, The idea is to be able to cancel all outstanding sub requests (for textures, draco meshes etc) with a single Apparently this does work for 3D tiles. |
Description
One way to cancel requests for an existing layer is to use loadOptions.
loadOptions: { fetch: { signal: abortSignal } }
This method works great for Tile3DLayer:
However, when I try to use the abortSignal in the same way for ScenegraphLayer, I get an error that crashes the app
Expected Behavior
ScenegraphLayer should be able to handle abort signals properly. This is essential for the layers to work well with AbortController. Right now, I have no way to cancel requests for these layers, which leads to performance issues for the app, which keeps making unnecessary requests.
Steps to Reproduce
I created a separate repository where I reproduced this error. The repository is open and accessible at this link: https://github.com/sprokazin/deck-cancel-glb. Steps to reproduce the bug:
Environment
The text was updated successfully, but these errors were encountered: