Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can vinejs support verifying bigint field types #31

Open
h25302 opened this issue Feb 10, 2024 · 4 comments
Open

Can vinejs support verifying bigint field types #31

h25302 opened this issue Feb 10, 2024 · 4 comments
Assignees
Labels
Semver: Minor Mainly new features and improvements Status: Awaiting More Information Waiting on the issue reporter or PR author to provide more information

Comments

@h25302
Copy link

h25302 commented Feb 10, 2024

Package version

1.7.1

Describe the bug

be similar to: vine.bigint()

Reproduction repo

No response

@RomainLanz RomainLanz added Status: Accepted The proposal or the feature has been accepted for the future versions Semver: Minor Mainly new features and improvements labels Feb 12, 2024
@RomainLanz RomainLanz self-assigned this Feb 12, 2024
@thetutlage
Copy link
Contributor

Need more info on this.

What will be the input value? Because you cannot transfer bigInts over HTTP.

Do remember, VineJS is not a generic validator that validates any JavaScript property.

@thetutlage thetutlage added Status: Awaiting More Information Waiting on the issue reporter or PR author to provide more information and removed Status: Accepted The proposal or the feature has been accepted for the future versions labels Mar 28, 2024
@RomainLanz
Copy link
Member

Probably the same type of validation that the one we had in AdonisJS 5.

This means parsing a huge number sent as a string to be cast in bigint by the validator.

@thetutlage
Copy link
Contributor

Okay, so basically attempting to cast any string and number values to BigInt and report error if unable to do so

@thetutlage
Copy link
Contributor

I will let this issue be on hold for a while and see if others wants to share what sort of validation rules they need related to a BigInt value.

For example, with numbers we have min, max, range and so on. So I want to collect the initial set of rules to implement for the BigInt as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Semver: Minor Mainly new features and improvements Status: Awaiting More Information Waiting on the issue reporter or PR author to provide more information
Projects
None yet
Development

No branches or pull requests

3 participants