-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some.object && some.object.fn()
and this.object && this.object.value
not handled
#51
Comments
|
And yeah, function calls are not currently handled. Doesn't seem to be super straight forward to fix either unfortunately :/ If you want to give it a try, pull requests are very welcome! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I used this tool on a large codebase, and came across some cases that were missed. Here's
everything I found:
GoogleChrome/lighthouse#13503 (comment)
(link to code at particular commit)
https://github.com/GoogleChrome/lighthouse/tree/11a6a030f3e29910be6dc1166f17e085c17da6da
I believe the following specific examples show every unique case missed.
Does not transform:
But it will transform this:
Perhaps function calls are not handled?
Does not transform:
or
Perhaps
this.
is not handled?The text was updated successfully, but these errors were encountered: