Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Border effect should respect PNG transparency / image shape #266

Open
JordanMagnuson opened this issue Sep 9, 2021 · 0 comments
Open

Border effect should respect PNG transparency / image shape #266

JordanMagnuson opened this issue Sep 9, 2021 · 0 comments

Comments

@JordanMagnuson
Copy link

Thank you for implementing border as an effect! This border implementation is much preferable to the old one.

One problem remains: the border effect does not respect PNG transparency: it only creates a rectangular border around any image, regardless of the image shape. It should work like the drop shadow effect, which respects PNG transparency, and creates a shadow around the particular shape of the image.

See this screenshot comparing miniPaint border effect to Photoshop stroke effect, for the same image: https://i.imgur.com/5qzt1Ml.jpeg

image
kmanaseryan added a commit to kmanaseryan/miniPaint that referenced this issue Sep 25, 2021
@kmanaseryan
Issue viliusle#266 - Apply styling
6868547
kmanaseryan added a commit to kmanaseryan/miniPaint that referenced this issue Sep 25, 2021
@kmanaseryan
Issue viliusle#266 - Improve border effect so that it will draw aroun…
25725d0 
…d nontransparent part of the image
kmanaseryan added a commit to kmanaseryan/miniPaint that referenced this issue Sep 25, 2021
@kmanaseryan
Issue viliusle#266 - Improve border effect so that it will draw aroun…
2652bdd 
…d nontransparent part of the image
@kmanaseryan kmanaseryan mentioned this issue Sep 25, 2021
Open
kmanaseryan added a commit to kmanaseryan/miniPaint that referenced this issue Sep 26, 2021
@kmanaseryan
Issue viliusle#266 - Improvements in border effect
8348660
kmanaseryan added a commit to kmanaseryan/miniPaint that referenced this issue Sep 26, 2021
@kmanaseryan
Issue viliusle#266 - Improvements in border effect
52f08e9
kmanaseryan added a commit to kmanaseryan/miniPaint that referenced this issue Sep 26, 2021
@kmanaseryan
Issue viliusle#266 - Implement the border effect logic in an isolated…
2537791 
… canvas
kmanaseryan added a commit to kmanaseryan/miniPaint that referenced this issue Oct 31, 2021
@kmanaseryan
Issue viliusle#266 - Revert back to prev border effect implementation
664348f
kmanaseryan added a commit to kmanaseryan/miniPaint that referenced this issue Oct 31, 2021
@kmanaseryan
Issue viliusle#266 - Draw border by analyising the pixel data
ee6cc19
kmanaseryan added a commit to kmanaseryan/miniPaint that referenced this issue Nov 19, 2021
@kmanaseryan
Issue viliusle#266 - Draw border by drawing lines through the points
8277c89 
- Constract all those points which are alinged on the edges of the image
- Constract separate shapes by using the points above
- Draw each shape through Canvas line drawing APIs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JordanMagnuson