Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs: Tab navigation events should pass the tab name property instead of title #611

Open
tjdennis opened this issue Mar 13, 2024 · 1 comment
Labels
area-tabs enhancement New feature or request

Comments

@tjdennis
Copy link

Hi,

I'm trying to use the OnShown() event on the Tabs component but the event arguments are providing the tab's Title property instead of the tab's Name property.

The two problems with the title are :

  • The event TabsEventArgs properties are null if you use a TitleTemplate sub-component.
  • The Title property is usually localized to the user's language so trying to perform logic on the value may not work.

You have a Name property on each Tab which you do use when calling the ShowTabByNameAsync() method to identify them in code. This should also be the names passed to the event arguments in TabsEventArgs.

I'm not sure if changing this will break other people's code, so maybe adding new ActiveTabName and PreviousActiveTabName properties could be added to the TabsEventArgs class.

Thanks!

@gvreddy04
Copy link
Contributor

@tjdennis Thank you for your valuable feedback. We will incorporate it in the upcoming release.

@gvreddy04 gvreddy04 added the enhancement New feature or request label Mar 14, 2024
@gvreddy04 gvreddy04 changed the title Tab navigation events should pass the tab name property instead of title Tabs: Tab navigation events should pass the tab name property instead of title Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-tabs enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants