Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer href in urlParsed #1630

Open
openscript opened this issue May 2, 2024 · 2 comments
Open

Offer href in urlParsed #1630

openscript opened this issue May 2, 2024 · 2 comments
Labels
enhancement ✨ New feature or request

Comments

@openscript
Copy link

Description

In my opinion urlParsed should contain a href. My reasoning is URL also contains that and the DX would improve.

For example https://vike.dev/i18n describes:

const urlWithoutLocale = `${origin || ''}${pathnameWithoutLocale}${searchOriginal || ''}${hashOriginal || ''}`

This would become

const urlWithoutLocale = url.href.replace(url.pathname, url.pathnameWithoutLocale)
@openscript openscript added the enhancement ✨ New feature or request label May 2, 2024
@brillout
Copy link
Member

brillout commented May 2, 2024

Agreed 👍 Would you be up for PR for this as well? AFAICT this one should actually be fairly easy (easier than the other one).

(On a tangent, I was thinking it would also be nice to offer/document an easier way to manipulate the URL. The issue with url.href.replace(url.pathname, url.pathnameWithoutLocale) is that it may fail for example for a url.pathname that is /en and a URL /en?movies/endeavour which would become /?movies/deavour.)

@openscript
Copy link
Author

Would you be up for PR for this as well?

Sure, I'll give it a try. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants